linux-kernel - Re: [PATCH 1/4] pinctrl: qcom: lpass-lpi: set output value before enabling output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd829dcb-0b06-9edb-65f9-35ad240c5f17@linaro.org>
Date:   Fri, 10 Mar 2023 03:08:09 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     stable@...r.kernel.org
Subject: Re: [PATCH 1/4] pinctrl: qcom: lpass-lpi: set output value before
 enabling output



On 9.03.2023 16:49, Krzysztof Kozlowski wrote:
> As per Hardware Programming Guide, when configuring pin as output,
> set the pin value before setting output-enable (OE).  Similar approach
> is in main SoC TLMM pin controller.
> 
> Cc: <stable@...r.kernel.org>
> Fixes: 6e261d1090d6 ("pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>  drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
> index 87920257bb73..27fc8b671954 100644
> --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
> +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
> @@ -221,6 +221,15 @@ static int lpi_config_set(struct pinctrl_dev *pctldev, unsigned int group,
>  		}
>  	}
>  
> +	/*
> +	 * As per Hardware Programming Guide, when configuring pin as output,
> +	 * set the pin value before setting output-enable (OE).
> +	 */
> +	if (output_enabled) {
> +		val = u32_encode_bits(value ? 1 : 0, LPI_GPIO_VALUE_OUT_MASK);
> +		lpi_gpio_write(pctrl, group, LPI_GPIO_VALUE_REG, val);
> +	}
> +
>  	val = lpi_gpio_read(pctrl, group, LPI_GPIO_CFG_REG);
>  
>  	u32p_replace_bits(&val, pullup, LPI_GPIO_PULL_MASK);
> @@ -230,11 +239,6 @@ static int lpi_config_set(struct pinctrl_dev *pctldev, unsigned int group,
>  
>  	lpi_gpio_write(pctrl, group, LPI_GPIO_CFG_REG, val);
>  
> -	if (output_enabled) {
> -		val = u32_encode_bits(value ? 1 : 0, LPI_GPIO_VALUE_OUT_MASK);
> -		lpi_gpio_write(pctrl, group, LPI_GPIO_VALUE_REG, val);
> -	}
> -
>  	return 0;
>  }
>