linux-kernel - Re: [PATCH v2 1/1] kbuild: deb-pkg: default dpkg-buildpackage --build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNASJeECGBiaWNjdhDbnBP3-8TKUOCXXbmbu8C9+Qa4FDxg@mail.gmail.com>
Date:   Fri, 10 Mar 2023 23:37:18 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Bastian Germann <bage@...utronix.de>
Cc:     Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nicolas Schier <nicolas@...sle.eu>,
        linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] kbuild: deb-pkg: default dpkg-buildpackage --build

On Tue, Mar 7, 2023 at 8:20 PM Bastian Germann <bage@...utronix.de> wrote:
>
> deb-pkg's dpkg-buildpackage invocation was added --build=source,binary
> recently. Before, it relied on the default, which is the same, so it
> no difference for the built packages.
>
> However, the explicit --build eliminates overriding it via DPKG_FLAGS,
> which used to fill the gap of generating only a source package without
> building it.
>
> Recover the old, default behavior.
>
> Fixes: 7bf4582d7aad ("kbuild: deb-pkg: create source package without cleaning")
> Signed-off-by: Bastian Germann <bage@...utronix.de>
> ---
>  scripts/Makefile.package | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.package b/scripts/Makefile.package
> index b941e6341b36..fe1721915a59 100644
> --- a/scripts/Makefile.package
> +++ b/scripts/Makefile.package
> @@ -120,7 +120,7 @@ debian-orig: linux.tar.gz debian
>  PHONY += deb-pkg
>  deb-pkg: debian-orig
>         +dpkg-buildpackage -r$(KBUILD_PKG_ROOTCMD) -a$$(cat debian/arch) $(DPKG_FLAGS) \
> -               --build=source,binary -nc -us -uc
> +               -nc -us -uc
>
>  PHONY += bindeb-pkg
>  bindeb-pkg: debian
> --
> 2.39.2
>



I applied this, then dropped it.

This patch is wrong.


If this patch is applied, 'make deb-pkg'
would not produce the source package at all.


Now I recalled the reason why I added this.



dpkg-buildpackage(1):

 full
     Builds everything.  This is an alias for source,any,all, and the
     same as the default case when no build option is specified.
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^


NACK





--
Best Regards
Masahiro Yamada