linux-kernel - Re: [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 11 Mar 2023 11:05:43 +0100
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Jianhua Lu <lujianhua000@...il.com>
Cc:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

Le 10/03/2023 à 23:50, Linus Walleij a écrit :
> On Fri, Mar 10, 2023 at 7:35 PM Jianhua Lu <lujianhua000@...il.com> wrote:
>> On Fri, Mar 10, 2023 at 07:10:21PM +0100, Konrad Dybcio wrote:
>>>
>>>> +#define mipi_dsi_dual_dcs_write_seq(dsi0, dsi1, cmd, seq...)        \
>>>> +           do {                                                 \
>>>> +                   mipi_dsi_dcs_write_seq(dsi0, cmd, seq);      \
>>>> +                   mipi_dsi_dcs_write_seq(dsi1, cmd, seq);      \
>>>> +           } while (0)
>>> This should be in the same file as mipi_dsi_dcs_write_seq, imo
>> I have sent a patch to do it, upstream don't think this wrapper is a proper
>> approach to deal with dual dsi and wrap all of mipi_dsi_* function is
>> useless.
>> https://lore.kernel.org/lkml/20230310110542.6649-1-lujianhua000@gmail.com/
> 
> We can keep it locally if the fight isn't worthwhile, but I will try to enter
> the discussion.

It's ok to keep it in the driver until we find a way to move it in the generic includes.

Neil


> 
> Yours,
> Linus Walleij