linux-kernel - Re: [PATCH v2] 9P FS: Fix wild-memory-access write in v9fs_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f23b861f-25ea-785d-83b3-f66d924d663f@gmail.com>
Date:   Sat, 11 Mar 2023 16:08:24 +0400
From:   Ivan Orlov <ivan.orlov0322@...il.com>
To:     Christian Schoenebeck <linux_oss@...debyte.com>, ericvh@...il.com,
        lucho@...kov.net, asmadeus@...ewreck.org
Cc:     v9fs-developer@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
        skhan@...uxfoundation.org, himadrispandya@...il.com,
        syzbot+cb1d16facb3cc90de5fb@...kaller.appspotmail.com
Subject: Re: [PATCH v2] 9P FS: Fix wild-memory-access write in v9fs_get_acl

On 3/11/23 15:17, Christian Schoenebeck wrote:
> I would have written it in different style:
> 
>      if (buffer_size)
>          retval = -ERANGE;
>      else if (attr_size > SSIZE_MAX)
>          retval = -EOVERFLOW;
>      else
>          retval = attr_size; /* request to get the attr_size */
> 
> But the behaviour change itself makes sense, so:
> 
> Reviewed-by: Christian Schoenebeck <linux_oss@...debyte.com>
> 
>>   	} else {
>>   		iov_iter_truncate(&to, attr_size);
>>   		retval = p9_client_read(attr_fid, 0, &to, &err);
>>
> 
> 

You are right, the condition can be simplified, thank you! I will 
rewrite it, send as v3 and mention you in 'suggested-by'.