linux-kernel - Re: [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a simple-mfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2b368fdc-8c81-8e87-68fc-866aef904413@linaro.org>
Date:   Sat, 11 Mar 2023 13:40:43 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC 00/15] Convert Qualcomm RPM message RAM to a
 simple-mfd



On 11.03.2023 12:24, Dmitry Baryshkov wrote:
> On Sat, 11 Mar 2023 at 03:21, Konrad Dybcio <konrad.dybcio@...aro.org> wrote:
>>
>> The Qualcomm RPM message RAM is a part of the RPM low-power processor's
>> actual RAM that's exposed to the Application Processors as a MMIO-mapped
>> region. It contains a couple of things, most notably the RPM master stats,
>> detailing per-master (read: per-subsystem) sleep/wake statistics and an
>> interrupt controller that's crucial to achieving full SoC clock and/or
>> power collapse states (the MPM). This series tries to prepare the MSG
>> RAM node to be a host for such devices.
>>
>> Depends on https://lore.kernel.org/linux-arm-msm/20230308011705.291337-1-konrad.dybcio@linaro.org/
>>
>> to solve a warning in the example.
>>
>> The DTS commits don't add -cells or -ranges, as without children they're
>> not of very much use. They'll be introduced along with subnodes.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>> ---
>> Konrad Dybcio (15):
>>       dt-bindings: mfd: Split out Qcom RPM MSG RAM
>>       arm64: dts: qcom: msm8916: Add simple-mfd to rpm_msg_ram
>>       arm64: dts: qcom: msm8953: Add simple-mfd to rpm_msg_ram
>>       arm64: dts: qcom: msm8976: Add simple-mfd to rpm_msg_ram
>>       arm64: dts: qcom: msm8994: Add simple-mfd to rpm_msg_ram
>>       arm64: dts: qcom: msm8996: Add simple-mfd to rpm_msg_ram
>>       arm64: dts: qcom: msm8998: Add simple-mfd to rpm_msg_ram
>>       arm64: dts: qcom: qcs404: Add simple-mfd to rpm_msg_ram
>>       arm64: dts: qcom: sdm630: Add simple-mfd to rpm_msg_ram
>>       arm64: dts: qcom: sm6115: Add simple-mfd to rpm_msg_ram
>>       arm64: dts: qcom: sm6125: Add simple-mfd to rpm_msg_ram
>>       arm64: dts: qcom: sm6375: Add simple-mfd to rpm_msg_ram
>>       ARM: dts: qcom-apq8084: Add simple-mfd to rpm_msg_ram
>>       ARM: dts: qcom-msm8226: Add simple-mfd to rpm_msg_ram
>>       ARM: dts: qcom-msm8974: Add simple-mfd to rpm_msg_ram
> 
> These commits do not demonstrate the need for simple-mfd (other than
> qcom,mpm being mentioned in bindings). I'd suggest limiting the RFC to
> a single platform populated with rpm_msg_ram child devices. This way
> we can better understand the needs and the requirements for these
> patches.
Right.. I was debating whether to just send the bindings as a RFC, but
then I'd have to make simple-mfd optional just to retire it soon..

Konrad
> 
>