linux-kernel - Re: [PATCH v1 08/14] iommu/arm-smmu-v3: Prepare for nested domain support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZAx2x8iCc0cAFk19@Asurada-Nvidia>
Date:   Sat, 11 Mar 2023 04:40:39 -0800
From:   Nicolin Chen <nicolinc@...dia.com>
To:     Robin Murphy <robin.murphy@....com>
CC:     <jgg@...dia.com>, <will@...nel.org>, <eric.auger@...hat.com>,
        <kevin.tian@...el.com>, <baolu.lu@...ux.intel.com>,
        <joro@...tes.org>, <shameerali.kolothum.thodi@...wei.com>,
        <jean-philippe@...aro.org>, <linux-arm-kernel@...ts.infradead.org>,
        <iommu@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 08/14] iommu/arm-smmu-v3: Prepare for nested domain
 support

On Fri, Mar 10, 2023 at 08:39:20PM +0000, Robin Murphy wrote:

> > @@ -1277,6 +1295,7 @@ static void arm_smmu_write_strtab_ent(struct arm_smmu_master *master, u32 sid,
> >               switch (smmu_domain->stage) {
> >               case ARM_SMMU_DOMAIN_S1:
> >                       s1_cfg = &smmu_domain->s1_cfg;
> > +                     s2_cfg = to_s2_cfg(smmu_domain);
> 
> TBH I'd say you only need a 2-line change here. All the other cases
> below are when the stage is guaranteed to be ARM_SMMU_DOMAIN_S2 (once
> ARM_SMMU_DOMAIN_NESTED is gone), so pretending it might be otherwise
> seems unnecessarily confusing.

Oh right...I will drop those.

Thanks!
Nic