linux-kernel - Re: [PATCH] pata_parport: fix possible memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2223c1dc-1869-a307-e5da-772cb27b34e5@omp.ru>
Date:   Sat, 11 Mar 2023 23:23:25 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Sergei Shtylyov <sergei.shtylyov@...il.com>,
        Ondrej Zary <linux@...y.sk>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>
CC:     Dan Carpenter <error27@...il.com>, Christoph Hellwig <hch@....de>,
        <linux-ide@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pata_parport: fix possible memory leak

On 3/11/23 11:19 PM, Sergei Shtylyov wrote:

>> When ida_alloc() fails, "pi" is not freed although the misleading
>> comment says otherwise.
>> Move the ida_alloc() call up so we really don't have to free it.

   Wait, but don't we still need to call kfree() in pi_init_one()?

>> Reported-by: kernel test robot <lkp@...el.com>
>> Reported-by: Dan Carpenter <error27@...il.com>
>> Link: https://lore.kernel.org/r/202303111822.IHNchbkp-lkp@intel.com/
>> Signed-off-by: Ondrej Zary <linux@...y.sk>
> 
> Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>
> 
> [...]

MBR, Sergey