linux-kernel - Re: [PATCH] pata_parport: fix possible memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <202303112211.57761.linux@zary.sk>
Date:   Sat, 11 Mar 2023 22:11:57 +0100
From:   Ondrej Zary <linux@...y.sk>
To:     Sergey Shtylyov <s.shtylyov@....ru>
Cc:     Sergei Shtylyov <sergei.shtylyov@...il.com>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Dan Carpenter <error27@...il.com>,
        Christoph Hellwig <hch@....de>, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pata_parport: fix possible memory leak

On Saturday 11 March 2023 21:23:25 Sergey Shtylyov wrote:
> On 3/11/23 11:19 PM, Sergei Shtylyov wrote:
> 
> >> When ida_alloc() fails, "pi" is not freed although the misleading
> >> comment says otherwise.
> >> Move the ida_alloc() call up so we really don't have to free it.
> 
>    Wait, but don't we still need to call kfree() in pi_init_one()?

If it fails at device_register, the dev.release is already set to pata_parport_dev_release which does the kfree(). put_device() should call it. If it fails later, device_unregister() should do it.
 
> >> Reported-by: kernel test robot <lkp@...el.com>
> >> Reported-by: Dan Carpenter <error27@...il.com>
> >> Link: https://lore.kernel.org/r/202303111822.IHNchbkp-lkp@intel.com/
> >> Signed-off-by: Ondrej Zary <linux@...y.sk>
> > 
> > Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>
> > 
> > [...]
> 
> MBR, Sergey
> 


-- 
Ondrej Zary