linux-kernel - Re: [PATCH V2 1/2] ASoC: max98363: add soundwire amplifier driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6fbd4471-9f72-c87c-3803-90f7224abce0@linux.intel.com>
Date:   Mon, 13 Mar 2023 09:46:31 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     “Ryan <ryan.lee.analog@...il.com>,
        lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz,
        tiwai@...e.com, krzysztof.kozlowski@...aro.org,
        rf@...nsource.cirrus.com, ckeepax@...nsource.cirrus.com,
        herve.codina@...tlin.com, wangweidong.a@...nic.com,
        james.schulman@...rus.com,
        ajye_huang@...pal.corp-partner.google.com, shumingf@...ltek.com,
        povik+lin@...ebit.org, flatmax@...tmax.com,
        linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
        robh+dt@...nel.org, devicetree@...r.kernel.org,
        ryans.lee@...log.com
Subject: Re: [PATCH V2 1/2] ASoC: max98363: add soundwire amplifier driver


> +	ret = sdw_stream_add_slave(max98363->slave, &stream_config,
> +				   &port_config, 1, stream);
> +	if (ret) {
> +		dev_err(dai->dev, "Unable to configure port\n");
> +		return ret;
> +	}
> +
> +	if (params_channels(params) > 16) {
> +		dev_err(component->dev, "Unsupported channels %d\n",
> +			params_channels(params));
> +		return -EINVAL;
> +	}

Do you actually support more than 8 channels?

The data port DPnPrepareCtl and DPn_ChannelEn registers expose 8
channels max. It's always possible to 'cheat' by packing two channels in
the same sample, but that would require custom signaling between manager
and peripheral that isn't present.

Could it be a left-over from a TDM implementation?

The rest of the patch looks fine.