linux-kernel - RE: [PATCH V2 2/2] ASoC: dt-bindings: max98363: add soundwire amplifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <SJ0PR03MB6681C6888CACE552BC9F2C268ABD9@SJ0PR03MB6681.namprd03.prod.outlook.com>
Date:   Fri, 17 Mar 2023 17:22:28 +0000
From:   "Lee, RyanS" <RyanS.Lee@...log.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        “Ryan <ryan.lee.analog@...il.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "rf@...nsource.cirrus.com" <rf@...nsource.cirrus.com>,
        "ckeepax@...nsource.cirrus.com" <ckeepax@...nsource.cirrus.com>,
        "pierre-louis.bossart@...ux.intel.com" 
        <pierre-louis.bossart@...ux.intel.com>,
        "herve.codina@...tlin.com" <herve.codina@...tlin.com>,
        "wangweidong.a@...nic.com" <wangweidong.a@...nic.com>,
        "james.schulman@...rus.com" <james.schulman@...rus.com>,
        "ajye_huang@...pal.corp-partner.google.com" 
        <ajye_huang@...pal.corp-partner.google.com>,
        "shumingf@...ltek.com" <shumingf@...ltek.com>,
        "povik+lin@...ebit.org" <povik+lin@...ebit.org>,
        "flatmax@...tmax.com" <flatmax@...tmax.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH V2 2/2] ASoC: dt-bindings: max98363: add soundwire
 amplifier

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Saturday, March 11, 2023 1:10 AM
> To: “Ryan <ryan.lee.analog@...il.com>; lgirdwood@...il.com;
> broonie@...nel.org; perex@...ex.cz; tiwai@...e.com;
> rf@...nsource.cirrus.com; ckeepax@...nsource.cirrus.com; pierre-
> louis.bossart@...ux.intel.com; herve.codina@...tlin.com;
> wangweidong.a@...nic.com; james.schulman@...rus.com;
> ajye_huang@...pal.corp-partner.google.com; shumingf@...ltek.com;
> povik+lin@...ebit.org; flatmax@...tmax.com; linux-kernel@...r.kernel.org;
> alsa-devel@...a-project.org; robh+dt@...nel.org;
> devicetree@...r.kernel.org; Lee, RyanS <RyanS.Lee@...log.com>
> Subject: Re: [PATCH V2 2/2] ASoC: dt-bindings: max98363: add soundwire
> amplifier
> 
> [External]
> 
> On 11/03/2023 02:14, “Ryan wrote:
> > From: Ryan Lee <ryans.lee@...log.com>
> >
> > This patch adds dt-bindings information for Analog Devices MAX98363
> > SoundWire Amplifier.
> >
> > Signed-off-by: Ryan Lee <ryans.lee@...log.com>
> > ---
> > Changes from v1:
> >   Fixed a syntax error for the 'dt_binding_check' build.
> >   Removed unnecessary properties.
> >   Added description about SoundWire device ID of MAX98363
> >
> >  .../bindings/sound/adi,max98363.yaml          | 42 +++++++++++++++++++
> >  1 file changed, 42 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/sound/adi,max98363.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/adi,max98363.yaml
> > b/Documentation/devicetree/bindings/sound/adi,max98363.yaml
> > new file mode 100644
> > index 000000000000..0e71b6c84007
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/adi,max98363.yaml
> > @@ -0,0 +1,42 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> >
> +https://urldefense.com/v3/__http://devicetree.org/schemas/sound/adi,m
> >
> +ax98363.yaml*__;Iw!!A3Ni8CS0y2Y!4ewyyKINBBx1aj2efOARVpQxC3TuNeK
> Cm-K4O
> > +YvWFPfQFCpbhs6NefkJU5s0G-h625nyj5ItjNe-N4VH002-sZAucYo$
> > +$schema:
> > +https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/core.y
> > +aml*__;Iw!!A3Ni8CS0y2Y!4ewyyKINBBx1aj2efOARVpQxC3TuNeKCm-
> K4OYvWFPfQFC
> > +pbhs6NefkJU5s0G-h625nyj5ItjNe-N4VH002-Pnhea3U$
> > +
> > +title: Analog Devices MAX98363 SoundWire Amplifier
> > +
> > +maintainers:
> > +  - Ryan Lee <ryans.lee@...log.com>
> > +
> > +description:
> > +  The MAX98363 is a SoundWire input Class D mono amplifier that
> > +  supports MIPI SoundWire v1.2-compatible digital interface for
> > +  audio and control data.
> > +  SoundWire peripheral device ID of MAX98363 is 0x3X019F836300
> > +  where X is the peripheral device unique ID decoded from pin.
> > +  It supports up to 10 peripheral devices(0x0 to 0x9).
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,max98363
> 
> Aren't soundwire devices supposed to use device ID as compatible?

You are right. ACPI device ID is no longer valid.
I shall add the proper SoundWire device ID for the amp.
> 
> Missing blank line
> 
> > +  reg:
> > +    maxItems: 1
> > +    description: Peripheral-device unique ID decoded from pin.
> > +
> 
> It's not a DAI?

It is DAI. I suppose I need to add #sound-dai-cells' info. I shall add it.

> 
> > +required:
> > +  - compatible
> > +  - reg
> 
> Missing blank line

Thanks. I shall fix this.
> 
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    soundwire {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +        amplifier@3 {
> > +            compatible = "adi,max98363";
> > +            reg = <0x3>;
> 
> That looks a bit different than regular SoundWire bus. I would argue that it's
> not SoundWire at all...

Thanks for the review. My apologies. Your statement is fair.
I shall modify the example.

> 
> 
> > +        };
> > +    };
> 
> Best regards,
> Krzysztof