linux-kernel - RE: [PATCH V2 1/2] ASoC: max98363: add soundwire amplifier driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR03MB66812CB6A3AB99B87EE870438A879@SJ0PR03MB6681.namprd03.prod.outlook.com>
Date:   Thu, 23 Mar 2023 17:51:01 +0000
From:   "Lee, RyanS" <RyanS.Lee@...log.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        “Ryan <ryan.lee.analog@...il.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
        "rf@...nsource.cirrus.com" <rf@...nsource.cirrus.com>,
        "ckeepax@...nsource.cirrus.com" <ckeepax@...nsource.cirrus.com>,
        "herve.codina@...tlin.com" <herve.codina@...tlin.com>,
        "wangweidong.a@...nic.com" <wangweidong.a@...nic.com>,
        "james.schulman@...rus.com" <james.schulman@...rus.com>,
        "ajye_huang@...pal.corp-partner.google.com" 
        <ajye_huang@...pal.corp-partner.google.com>,
        "shumingf@...ltek.com" <shumingf@...ltek.com>,
        "povik+lin@...ebit.org" <povik+lin@...ebit.org>,
        "flatmax@...tmax.com" <flatmax@...tmax.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH V2 1/2] ASoC: max98363: add soundwire amplifier driver

> -----Original Message-----
> From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> Sent: Monday, March 13, 2023 7:47 AM
> To: “Ryan <ryan.lee.analog@...il.com>; lgirdwood@...il.com;
> broonie@...nel.org; perex@...ex.cz; tiwai@...e.com;
> krzysztof.kozlowski@...aro.org; rf@...nsource.cirrus.com;
> ckeepax@...nsource.cirrus.com; herve.codina@...tlin.com;
> wangweidong.a@...nic.com; james.schulman@...rus.com;
> ajye_huang@...pal.corp-partner.google.com; shumingf@...ltek.com;
> povik+lin@...ebit.org; flatmax@...tmax.com; linux-kernel@...r.kernel.org;
> alsa-devel@...a-project.org; robh+dt@...nel.org;
> devicetree@...r.kernel.org; Lee, RyanS <RyanS.Lee@...log.com>
> Subject: Re: [PATCH V2 1/2] ASoC: max98363: add soundwire amplifier driver
> 
> [External]
> 
> 
> > +	ret = sdw_stream_add_slave(max98363->slave, &stream_config,
> > +				   &port_config, 1, stream);
> > +	if (ret) {
> > +		dev_err(dai->dev, "Unable to configure port\n");
> > +		return ret;
> > +	}
> > +
> > +	if (params_channels(params) > 16) {
> > +		dev_err(component->dev, "Unsupported channels %d\n",
> > +			params_channels(params));
> > +		return -EINVAL;
> > +	}
> 
> Do you actually support more than 8 channels?
> 
> The data port DPnPrepareCtl and DPn_ChannelEn registers expose 8
> channels max. It's always possible to 'cheat' by packing two channels in the
> same sample, but that would require custom signaling between manager and
> peripheral that isn't present.
> 
> Could it be a left-over from a TDM implementation?

Thanks for the comment.
I think it is a left-over from a TDM implementation.
I shall modify the code to accept only max number of channels supported by the amp.

> 
> The rest of the patch looks fine.