linux-kernel - Re: [PATCH v5] scsi: support packing multi-segment in UNMAP command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e3ffff0-6cc8-b01a-4d2e-5ec49a936415@kernel.org>
Date:   Mon, 13 Mar 2023 09:44:47 +0800
From:   Chao Yu <chao@...nel.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     martin.petersen@...cle.com, jejb@...ux.ibm.com, bvanassche@....org,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] scsi: support packing multi-segment in UNMAP command

On 2023/3/10 22:02, Christoph Hellwig wrote:
>> -	/* If command type is WRITE or DISCARD, set bitmap as dirty */
>> -	if (ufshpb_is_write_or_discard(cmd)) {
>> +	/* If command type is WRITE, set bitmap as dirty */
>> +	if (op_is_write(req_op(scsi_cmd_to_rq(cmd)))) {
> 
> Umm, a driver has absolutely no business poking into the UNMAP
> payload.   Someone needs to fix the UFS driver first to not do this.

IIUC，originally, HPB driver tries to lookup LBA range{,s} from WRITE/DISCARD
request, and will dirty mapped HPB regions based on LBA range{,s}, do you mean
HPB driver should not parse DISCARD request?