linux-kernel - Re: [PATCH v5] scsi: support packing multi-segment in UNMAP command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBhY5wL9W/QDwIfE@infradead.org>
Date:   Mon, 20 Mar 2023 06:00:23 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Chao Yu <chao@...nel.org>
Cc:     Christoph Hellwig <hch@...radead.org>, martin.petersen@...cle.com,
        jejb@...ux.ibm.com, bvanassche@....org, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] scsi: support packing multi-segment in UNMAP command

On Mon, Mar 13, 2023 at 09:44:47AM +0800, Chao Yu wrote:
> IIUC，originally, HPB driver tries to lookup LBA range{,s} from WRITE/DISCARD
> request, and will dirty mapped HPB regions based on LBA range{,s}, do you mean
> HPB driver should not parse DISCARD request?

Eww..  This just means we really need to drop this bogus HPB code.
It will otherwise break every single time when a new SCSI command get
added that modifies LBA content.