[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <518f47e4-7fc6-7715-93dd-2a3b1b4acadf@starfivetech.com>
Date: Tue, 14 Mar 2023 22:18:58 +0800
From: Hal Feng <hal.feng@...rfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Rob Herring <robh@...nel.org>
CC: Marc Zyngier <maz@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Ben Dooks <ben.dooks@...ive.com>,
Philipp Zabel <p.zabel@...gutronix.de>,
Stephen Boyd <sboyd@...nel.org>,
<linux-riscv@...ts.infradead.org>, Conor Dooley <conor@...nel.org>,
"Emil Renner Berthing" <emil.renner.berthing@...onical.com>,
Thomas Gleixner <tglx@...utronix.de>,
Paul Walmsley <paul.walmsley@...ive.com>,
Albert Ou <aou@...s.berkeley.edu>,
<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
Rob Herring <robh+dt@...nel.org>,
"Daniel Lezcano" <daniel.lezcano@...aro.org>,
<linux-clk@...r.kernel.org>,
"Michael Turquette" <mturquette@...libre.com>,
Palmer Dabbelt <palmer@...belt.com>
Subject: Re: [PATCH v5 11/21] dt-bindings: clock: Add StarFive JH7110 system
clock and reset generator
On Mon, 13 Mar 2023 08:51:20 +0100, Krzysztof Kozlowski wrote:
> On 13/03/2023 03:47, Hal Feng wrote:
>> On Sat, 11 Mar 2023 08:17:00 -0600, Rob Herring wrote:
>>> On Sat, 11 Mar 2023 17:07:23 +0800, Hal Feng wrote:
>>>> From: Emil Renner Berthing <kernel@...il.dk>
>>>>
>>>> Add bindings for the system clock and reset generator (SYSCRG) on the
>>>> JH7110 RISC-V SoC by StarFive Ltd.
>>>>
>>>> Signed-off-by: Emil Renner Berthing <kernel@...il.dk>
>>>> Signed-off-by: Hal Feng <hal.feng@...rfivetech.com>
>>>> ---
>>>> .../clock/starfive,jh7110-syscrg.yaml | 104 +++++++++
>>>> MAINTAINERS | 8 +-
>>>> .../dt-bindings/clock/starfive,jh7110-crg.h | 203 ++++++++++++++++++
>>>> .../dt-bindings/reset/starfive,jh7110-crg.h | 142 ++++++++++++
>>>> 4 files changed, 454 insertions(+), 3 deletions(-)
>>>> create mode 100644 Documentation/devicetree/bindings/clock/starfive,jh7110-syscrg.yaml
>>>> create mode 100644 include/dt-bindings/clock/starfive,jh7110-crg.h
>>>> create mode 100644 include/dt-bindings/reset/starfive,jh7110-crg.h
>>>>
>>>
>>>
>>> Please add Acked-by/Reviewed-by tags when posting new versions. However,
>>> there's no need to repost patches *only* to add the tags. The upstream
>>> maintainer will do that for acks received on the version they apply.
>>>
>>> If a tag was not added on purpose, please state why and what changed.
>>>
>>> Missing tags:
>>>
>>> Reviewed-by: Rob Herring <robh@...nel.org>
>>
>> This patch has been changed a lot and I am not sure whether it's still
>> the one you want. So I removed the Reviewed-by tag.
>
> Then mention it in changelog, just like Rob asked:
> "If a tag was not added on purpose, please state why and what changed."
> I don't see any explanation in the changelog about it.
So sorry for missing that. Thank you for your suggestions.
Best regards,
Hal
Powered by blists - more mailing lists