linux-kernel - Re: [ PATCH v4 6/6] sign-file: improve help message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3755170.1678810810@warthog.procyon.org.uk>
Date:   Tue, 14 Mar 2023 16:20:10 +0000
From:   David Howells <dhowells@...hat.com>
To:     Shreenidhi Shedi <yesshedi@...il.com>
Cc:     dhowells@...hat.com, dwmw2@...radead.org,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        sshedi@...are.com
Subject: Re: [ PATCH v4 6/6] sign-file: improve help message

Shreenidhi Shedi <yesshedi@...il.com> wrote:

> +	exit(retval);

Should be "exit(2)".

> +	fprintf(stderr, "\nExamples:\n");
> +
> +	fprintf(stderr, "\nRegular signing:\n");

You need to distinguish the two lines as they both look like headings when one
is actually a subheading of the other.

> +	fprintf(stderr, "scripts/sign-file -a sha512 -p certs/signing_key.pem ");
> +	fprintf(stderr, "-x certs/signing_key.x509 <module>\n");


David