lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20df2a0e-def9-632a-865a-1b6569071f76@gmail.com>
Date:   Mon, 20 Mar 2023 21:17:53 +0530
From:   Shreenidhi Shedi <yesshedi@...il.com>
To:     David Howells <dhowells@...hat.com>
Cc:     dwmw2@...radead.org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, sshedi@...are.com
Subject: Re: [ PATCH v4 1/6] sign-file: refactor argument parsing logic

On Tue, 14-Mar-2023 21:51, David Howells wrote:
> Shreenidhi Shedi <yesshedi@...il.com> wrote:
> 
>> +		{"privkey", required_argument, 0, 'p'},
> 
> Please don't change the flag assignment - you can add new ones, but don't
> change the existing.  This program is used by a lot of scripts.
> 
> David
> 

David, thanks for the review. I will address the issues and send revised 
patches soon.

--
Shedi

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ