linux-kernel - Re: [PATCH AUTOSEL 6.2 08/30] selftests/bpf: check that modifier resolves after pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBiAPngOtzSwDhFz@kroah.com>
Date:   Mon, 20 Mar 2023 16:48:14 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Lorenz Bauer <lmb@...valent.com>
Cc:     Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Martin KaFai Lau <martin.lau@...nel.org>,
        ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
        shuah@...nel.org, yhs@...com, eddyz87@...il.com, sdf@...gle.com,
        error27@...il.com, iii@...ux.ibm.com, memxor@...il.com,
        bpf@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.2 08/30] selftests/bpf: check that modifier
 resolves after pointer

On Mon, Mar 20, 2023 at 03:31:42PM +0000, Lorenz Bauer wrote:
> On Mon, Mar 20, 2023 at 12:53 AM Sasha Levin <sashal@...nel.org> wrote:
> >
> > From: Lorenz Bauer <lorenz.bauer@...valent.com>
> >
> > [ Upstream commit dfdd608c3b365f0fd49d7e13911ebcde06b9865b ]
> >
> > Add a regression test that ensures that a VAR pointing at a
> > modifier which follows a PTR (or STRUCT or ARRAY) is resolved
> > correctly by the datasec validator.
> >
> > Signed-off-by: Lorenz Bauer <lmb@...valent.com>
> > Link: https://lore.kernel.org/r/20230306112138.155352-3-lmb@isovalent.com
> > Signed-off-by: Martin KaFai Lau <martin.lau@...nel.org>
> > Signed-off-by: Sasha Levin <sashal@...nel.org>
> 
> Hi Sasha,
> 
> Can you explain why this patch was selected? I'd prefer to not
> backport the test, since it frequently leads to breakage when trying
> to build selftests/bpf on stable kernels.

Why would it break?  Is that because the test is buggy, or the kernel is
buggy?

thanks,

greg k-h