linux-kernel - Re: [PATCH v2] scsi: ufs: core: print trs for pending requests in MCQ mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bde102c7-ab4f-a301-072f-8d6b7acde8a8@acm.org>
Date:   Tue, 14 Mar 2023 11:09:55 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Ziqi Chen <quic_ziqichen@...cinc.com>, quic_asutoshd@...cinc.com,
        quic_cang@...cinc.com, quic_nguyenb@...cinc.com, mani@...nel.org,
        stanley.chu@...iatek.com, adrian.hunter@...el.com,
        beanhuo@...ron.com, avri.altman@....com, junwoo80.lee@...sung.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] scsi: ufs: core: print trs for pending requests in MCQ
 mode

On 3/14/23 04:16, Ziqi Chen wrote:
> +static bool ufshcd_print_tr_iter(struct request *req, void *priv)
> +{
> +	struct scsi_device *sdev = req->q->queuedata;
> +	struct Scsi_Host *shost = sdev->host;
> +	struct ufs_hba *hba = shost_priv(shost);
> +
> +	if (!IS_ERR_OR_NULL(hba))
> +		ufshcd_print_tr(hba, req->tag, *(bool *)priv);

I think that the "if (!IS_ERR_OR_NULL(hba))" code can be removed safely. 
Otherwise this patch looks good to me.

Thanks,

Bart.