linux-kernel - Re: [PATCH v2] scsi: ufs: core: print trs for pending requests in MCQ mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52bd8c2d-31f6-1f69-1d83-cf21ee66aec8@quicinc.com>
Date:   Wed, 15 Mar 2023 15:31:10 +0800
From:   Ziqi Chen <quic_ziqichen@...cinc.com>
To:     Bart Van Assche <bvanassche@....org>, <quic_asutoshd@...cinc.com>,
        <quic_cang@...cinc.com>, <quic_nguyenb@...cinc.com>,
        <mani@...nel.org>, <stanley.chu@...iatek.com>,
        <adrian.hunter@...el.com>, <beanhuo@...ron.com>,
        <avri.altman@....com>, <junwoo80.lee@...sung.com>,
        <martin.petersen@...cle.com>
CC:     <linux-scsi@...r.kernel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] scsi: ufs: core: print trs for pending requests in MCQ
 mode

sure

Best Regards,
Ziqi

On 3/15/2023 2:09 AM, Bart Van Assche wrote:
> On 3/14/23 04:16, Ziqi Chen wrote:
>> +static bool ufshcd_print_tr_iter(struct request *req, void *priv)
>> +{
>> +    struct scsi_device *sdev = req->q->queuedata;
>> +    struct Scsi_Host *shost = sdev->host;
>> +    struct ufs_hba *hba = shost_priv(shost);
>> +
>> +    if (!IS_ERR_OR_NULL(hba))
>> +        ufshcd_print_tr(hba, req->tag, *(bool *)priv);
> 
> I think that the "if (!IS_ERR_OR_NULL(hba))" code can be removed safely. 
> Otherwise this patch looks good to me.
> 
> Thanks,
> 
> Bart.