linux-kernel - Re: [PATCH] rtc: sun6i: Use of_property_present() for testing DT property presence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1845104.tdWV9SEqCh@jernej-laptop>
Date:   Tue, 14 Mar 2023 20:58:25 +0100
From:   Jernej Škrabec <jernej.skrabec@...il.com>
To:     Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Samuel Holland <samuel@...lland.org>,
        Rob Herring <robh@...nel.org>
Cc:     devicetree@...r.kernel.org, linux-rtc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: sun6i: Use of_property_present() for testing DT property
 presence

Dne petek, 10. marec 2023 ob 15:47:36 CET je Rob Herring napisal(a):
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>

Reviewed-by: Jernej Skrabec <jernej.skrabec@...il.com>

Best regards,
Jernej

> ---
>  drivers/rtc/rtc-sun6i.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
> index 7038f47d77ff..dc76537f1b62 100644
> --- a/drivers/rtc/rtc-sun6i.c
> +++ b/drivers/rtc/rtc-sun6i.c
> @@ -260,7 +260,7 @@ static void __init sun6i_rtc_clk_init(struct device_node
> *node, }
> 
>  	/* Switch to the external, more precise, oscillator, if present */
> -	if (of_get_property(node, "clocks", NULL)) {
> +	if (of_property_present(node, "clocks")) {
>  		reg |= SUN6I_LOSC_CTRL_EXT_OSC;
>  		if (rtc->data->has_losc_en)
>  			reg |= SUN6I_LOSC_CTRL_EXT_LOSC_EN;