linux-kernel - Re: [PATCH] nfc: trf7970a: mark OF related data as maybe unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Mar 2023 21:08:10 -0700
From:   Mark Greer <mgreer@...malcreek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Mark Greer <mgreer@...malcreek.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfc: trf7970a: mark OF related data as maybe unused

On Sat, Mar 11, 2023 at 12:13:28PM +0100, Krzysztof Kozlowski wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
> 
>   drivers/nfc/trf7970a.c:2232:34: error: ‘trf7970a_of_match’ defined but not used [-Werror=unused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/nfc/trf7970a.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c
> index 21d68664fe08..7eb17f46a815 100644
> --- a/drivers/nfc/trf7970a.c
> +++ b/drivers/nfc/trf7970a.c
> @@ -2229,7 +2229,7 @@ static const struct dev_pm_ops trf7970a_pm_ops = {
>  			   trf7970a_pm_runtime_resume, NULL)
>  };
>  
> -static const struct of_device_id trf7970a_of_match[] = {
> +static const struct of_device_id trf7970a_of_match[] __maybe_unused = {
>  	{.compatible = "ti,trf7970a",},
>  	{},
>  };
> -- 
> 2.34.1

Reviewed-by: Mark Greer <mgreer@...malcreek.com>