linux-kernel - Re: [PATCH] char: add driver for mps VR controller mp2891

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <390eefe7-c7c4-47b4-88f2-dcaa8bfaf8a8@app.fastmail.com>
Date:   Tue, 14 Mar 2023 11:20:31 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Noah (Wensheng) Wang" <Noah.Wang@...olithicpower.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Luke (Lijie) Jiang" <Luke.Jiang@...olithicpower.com>,
        "pebble liang" <pebble.liang@...olithicpower.com>,
        "Eva (Ting) Ma" <Eva.Ma@...olithicpower.com>
Subject: Re: [PATCH] char: add driver for mps VR controller mp2891

On Tue, Mar 14, 2023, at 10:18, Noah (Wensheng) Wang wrote:
> Hi Arnd, Grey:
> Thanks for the review.
>
> This driver will be used by facebook. This driver provide a device node 
> for userspace to get output voltage, input voltage, input current, 
> input power, output power and temperature of mp2891 controller through 
> I2C. This driver determine what kind of value the userspace wants 
> through the mp2891_write interface and return the corresponding value 
> when the interface mp2891_read is called.
>
> Signed-off-by: Noah Wang <Noah.Wang@...olithicpower.com>

Hi Noah,

>From your description, this sounds like it should be either part of the
drivers/hwmon/ framework, or drivers/iio/, but not a custom character
device.

Have you looked at those?

      Arnd