[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f9308bea-7059-bac7-a69d-3405babc9c8f@nvidia.com>
Date: Tue, 14 Mar 2023 11:46:07 +0000
From: Jon Hunter <jonathanh@...dia.com>
To: Dipen Patel <dipenp@...dia.com>,
Linus Walleij <linus.walleij@...aro.org>
Cc: thierry.reding@...il.com, linux-kernel@...r.kernel.org,
linux-tegra@...r.kernel.org, linux-gpio@...r.kernel.org,
devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
robh+dt@...nel.org, timestamp@...ts.linux.dev,
krzysztof.kozlowski+dt@...aro.org, brgl@...ev.pl, corbet@....net,
gregkh@...uxfoundation.org
Subject: Re: [PATCH V3 2/6] dt-bindings: timestamp: Add Tegra234 support
On 13/03/2023 23:49, Dipen Patel wrote:
> On 3/13/23 2:57 PM, Linus Walleij wrote:
>> Hi Dipen,
>>
>> thanks for maintaining HTE!
>>
>> On Fri, Mar 10, 2023 at 8:06 PM Dipen Patel <dipenp@...dia.com> wrote:
>>
>>> - nvidia,slices:
>>> - $ref: /schemas/types.yaml#/definitions/uint32
>>
>> I would not delete this, just mark it deprecated.
>>
>> nvidia,slices:
>> $ref: /schemas/types.yaml#/definitions/uint32
>> deprecated: true
>>
>> (And remove it from required, of course)
>>
>> This way you do not need to explain about why it was
>> deleted, it's just deprecated, which is fine.
>
> Great suggestion, thanks, will make changes in the next patch.
When you deprecate it, please make this a separate patch because it is
separate from adding Tegra234 support. Similarly you will want to have a
separate patch to remove support of the property from the driver as well.
Jon
--
nvpublic
Powered by blists - more mailing lists