linux-kernel - Re: [PATCH v2 2/2] staging: vme_user: remove unnecessary blank lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <64121af3e399e_253a1e294a2@iweiny-mobl.notmuch>
Date:   Wed, 15 Mar 2023 12:22:27 -0700
From:   Ira Weiny <ira.weiny@...el.com>
To:     Menna Mahmoud <eng.mennamahmoud.mm@...il.com>,
        Julia Lawall <julia.lawall@...ia.fr>
CC:     <gregkh@...uxfoundation.org>, <outreachy@...ts.linux.dev>,
        <martyn@...chs.me.uk>, <manohar.vanga@...il.com>,
        <zoo868e@...il.com>, <jerrykang026@...il.com>,
        <cuigaosheng1@...wei.com>, <arnd@...db.de>,
        <linux-kernel@...r.kernel.org>, <linux-staging@...ts.linux.dev>
Subject: Re: [PATCH v2 2/2] staging: vme_user: remove unnecessary blank lines

Menna Mahmoud wrote:
> 
> On ١٥‏/٣‏/٢٠٢٣ ١٥:٤٥, Julia Lawall wrote:
> >
> > On Wed, 15 Mar 2023, Menna Mahmoud wrote:
> >
> >> remove unnecessary blank lines before a close brace
> >> as reported by checkpatch script
> >>
> >> "CHECK: Blank lines aren't necessary before a close brace '}'"
> >>
> >> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@...il.com>
> >> ----
> > This should be three -s, not four.
> >
> >> changes in v2:
> >> 	edit commit message
> >> ---
> > -s aren't needed here.
> >
> > julia
> 
> 
> I see, Thanks Julia

I agree with Julia that they are not needed here but they also don't hurt
anything.  git format-patch (or b4 etc) add another '---' to the commit
message automatically.

https://lore.kernel.org/all/20221216-cxl-ev-log-v7-2-2316a5c8f7d8@intel.com/

So assuming you had something like ...

<quote>
----
changes in v2:
	edit commit message
</quote>

... in the patch commit message.  That is perfectly ok and I would not
worry about the tools adding a second '---'.

But as Julia said you must make sure to have only 3 '-'s.  :-D

Ira