linux-kernel - Re: [PATCH v2 2/2] staging: vme_user: remove unnecessary blank lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b37352ef-959e-d950-c0c6-32e1c7268b79@gmail.com>
Date:   Wed, 15 Mar 2023 15:50:19 +0200
From:   Menna Mahmoud <eng.mennamahmoud.mm@...il.com>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     gregkh@...uxfoundation.org, outreachy@...ts.linux.dev,
        martyn@...chs.me.uk, manohar.vanga@...il.com, zoo868e@...il.com,
        jerrykang026@...il.com, cuigaosheng1@...wei.com, arnd@...db.de,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v2 2/2] staging: vme_user: remove unnecessary blank lines


On ١٥‏/٣‏/٢٠٢٣ ١٥:٤٥, Julia Lawall wrote:
>
> On Wed, 15 Mar 2023, Menna Mahmoud wrote:
>
>> remove unnecessary blank lines before a close brace
>> as reported by checkpatch script
>>
>> "CHECK: Blank lines aren't necessary before a close brace '}'"
>>
>> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@...il.com>
>> ----
> This should be three -s, not four.
>
>> changes in v2:
>> 	edit commit message
>> ---
> -s aren't needed here.
>
> julia


I see, Thanks Julia

Menna


>
>>   drivers/staging/vme_user/vme_tsi148.c | 5 -----
>>   1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c
>> index bfa604043355..2f5eafd50934 100644
>> --- a/drivers/staging/vme_user/vme_tsi148.c
>> +++ b/drivers/staging/vme_user/vme_tsi148.c
>> @@ -1023,7 +1023,6 @@ static int tsi148_master_set(struct vme_master_resource *image, int enabled,
>>   err_res:
>>   err_window:
>>   	return retval;
>> -
>>   }
>>
>>   /*
>> @@ -1741,7 +1740,6 @@ static int tsi148_dma_list_add(struct vme_dma_list *list,
>>   				  list);
>>   		prev->descriptor.dnlau = cpu_to_be32(address_high);
>>   		prev->descriptor.dnlal = cpu_to_be32(address_low);
>> -
>>   	}
>>
>>   	return 0;
>> @@ -1773,7 +1771,6 @@ static int tsi148_dma_busy(struct vme_bridge *tsi148_bridge, int channel)
>>   		return 0;
>>   	else
>>   		return 1;
>> -
>>   }
>>
>>   /*
>> @@ -2220,7 +2217,6 @@ static int tsi148_crcsr_init(struct vme_bridge *tsi148_bridge,
>>   	}
>>
>>   	return 0;
>> -
>>   }
>>
>>   static void tsi148_crcsr_exit(struct vme_bridge *tsi148_bridge,
>> @@ -2530,7 +2526,6 @@ static int tsi148_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>>   	kfree(tsi148_bridge);
>>   err_struct:
>>   	return retval;
>> -
>>   }
>>
>>   static void tsi148_remove(struct pci_dev *pdev)
>> --
>> 2.34.1
>>
>>
>>