linux-kernel - RE: [PATCH 3/4] crypto: xilinx: Add ZynqMP RSA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Mar 2023 05:02:39 +0000
From:   "Harsha, Harsha" <harsha.harsha@....com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "michals@...inx.com" <michals@...inx.com>,
        "saratcha@...inx.com" <saratcha@...inx.com>,
        "git (AMD-Xilinx)" <git@....com>,
        "Shah, Dhaval (CPG-PSAV)" <dhaval.r.shah@....com>
Subject: RE: [PATCH 3/4] crypto: xilinx: Add ZynqMP RSA driver

Hi,

> -----Original Message-----
> From: Herbert Xu <herbert@...dor.apana.org.au>
> Sent: Friday, March 10, 2023 4:02 PM
> To: Harsha, Harsha <harsha.harsha@....com>
> Cc: davem@...emloft.net; linux-crypto@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> michals@...inx.com; saratcha@...inx.com; git (AMD-Xilinx) <git@....com>;
> Shah, Dhaval (CPG-PSAV) <dhaval.r.shah@....com>
> Subject: Re: [PATCH 3/4] crypto: xilinx: Add ZynqMP RSA driver
> 
> On Sat, Feb 18, 2023 at 11:08:08AM +0530, Harsha Harsha wrote:
> >
> > +			.cra_flags = CRYPTO_ALG_TYPE_AKCIPHER |
> > +				     CRYPTO_ALG_KERN_DRIVER_ONLY |
> > +				     CRYPTO_ALG_ALLOCATES_MEMORY |
> > +				     CRYPTO_ALG_NEED_FALLBACK,
> 
> The driver appears to be async so you should set the flag
> CRYPTO_ALG_ASYNC.

Thanks for the review.
For the RSA driver, below is the flow of operation:
RSA linux driver -> ATF -> Firmware -> RSA hardware engine.

To perform the operation, the request goes to the RSA HW engine. Once the operation is done, the response is sent back
via firmware and ATF to the linux driver. Meanwhile the API in the linux driver waits until the operation is complete.
This is why the driver is synchronous and therefore the CRYPTO_ALG_ASYNC flag is not set.

Regards,
Harsha

> 
> Thanks,
> --
> Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page:
> http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt