linux-kernel - Re: [PATCH 5/5] arm64: dts: rockchip: enable rk809 audio codec on the NanoPi R5 series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+E=qVcL1PNMcJ5M1zHQhZNpajxLJWWGQoXYeLER+OmV5Qz33A@mail.gmail.com>
Date:   Wed, 15 Mar 2023 16:54:18 -0700
From:   Vasily Khoruzhick <anarsoul@...il.com>
To:     Tianling Shen <cnsztl@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Peter Geis <pgwipeout@...il.com>, Andy Yan <andyshrk@....com>,
        Brian Norris <briannorris@...omium.org>,
        Chris Morgan <macromorgan@...mail.com>,
        Sebastian Reichel <sebastian.reichel@...labora.com>,
        Andrew Lunn <andrew@...n.ch>,
        Michael Riesch <michael.riesch@...fvision.net>,
        Maya Matuszczyk <maccraft123mc@...il.com>,
        Andrew Powers-Holmes <aholmes@...om.net>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] arm64: dts: rockchip: enable rk809 audio codec on the
 NanoPi R5 series

On Wed, Mar 15, 2023 at 9:03 AM Tianling Shen <cnsztl@...il.com> wrote:

Hi Tianling,

> +       rk809-sound {

There is no audio jack on my R5S, see [1] and I don't see it on R5C
either, see [2]. I don't see audio output on the pin header either.
How is it supposed to work?

> +               compatible = "simple-audio-card";
> +               simple-audio-card,format = "i2s";
> +               simple-audio-card,name = "Analog RK809";
> +               simple-audio-card,mclk-fs = <256>;
> +
> +               simple-audio-card,cpu {
> +                       sound-dai = <&i2s1_8ch>;
> +               };
> +
> +               simple-audio-card,codec {
> +                       sound-dai = <&rk809>;

It looks like rk809 doesn't have #sound-dai-cells property and it
results in a warning:

arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dtsi:48.27-50.5:
Warning (sound_dai_property): /rk809-sound/simple-audio-card,codec:
Missing property '#sound-dai-cells' in node /i2c@...40000/pmic@20 or
bad phandle (referred from sound-dai[0])

Regards,
Vasily

[1] https://wiki.friendlyelec.com/wiki/index.php/NanoPi_R5S
[2] https://wiki.friendlyelec.com/wiki/index.php/NanoPi_R5C