linux-kernel - Re: [PATCH 4.19-rt] workqueue: Fix deadlock due to recursive locking of pool->lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230316070850.q3bj3g7likfbg7jl@beryllium.lan>
Date:   Thu, 16 Mar 2023 08:08:50 +0100
From:   Daniel Wagner <wagi@...om.org>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     "Brennan Lamoreaux (VMware)" <brennanlamoreaux@...il.com>,
        linux-rt-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        blamoreaux@...are.com, frederic.martinsons@...il.com,
        srivatsa@...il.mit.edu, vsirnapalli@...are.com,
        amakhalov@...are.com, keerthanak@...are.com, ankitja@...are.com,
        bordoloih@...are.com, srivatsab@...are.com,
        Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH 4.19-rt] workqueue: Fix deadlock due to recursive locking
 of pool->lock

On Mon, Mar 13, 2023 at 10:36:41AM +0100, Sebastian Andrzej Siewior wrote:
> On 2023-02-28 14:49:38 [-0800], Brennan Lamoreaux (VMware) wrote:
> > Upstream commit d8bb65ab70f7 ("workqueue: Use rcuwait for wq_manager_wait")
> > replaced the waitqueue with rcuwait in the workqueue code. This change
> > involved removing the acquisition of pool->lock in put_unbound_pool(),
> > as it also adds the function wq_manager_inactive() which acquires this same
> > lock and is called one line later as a parameter to rcu_wait_event().
> 
> Daniel, I double checked and this patch is correct - the backport was
> faulty. Could you please pick it up and release an update?

Sure. I've updated the v4.19-rt branch and added this patch. Running local tests
now.