linux-kernel - RE: [PATCH v2 2/5] iommu/vt-d: Allow SVA with device-specific IOPF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB5276F50D86F8DA507CC18AF18CBC9@BN9PR11MB5276.namprd11.prod.outlook.com>
Date:   Thu, 16 Mar 2023 07:09:12 +0000
From:   "Tian, Kevin" <kevin.tian@...el.com>
To:     Lu Baolu <baolu.lu@...ux.intel.com>,
        "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>
CC:     Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
        "Robin Murphy" <robin.murphy@....com>,
        "Yu, Fenghua" <fenghua.yu@...el.com>,
        "Jiang, Dave" <dave.jiang@...el.com>,
        Vinod Koul <vkoul@...nel.org>,
        Jacob Pan <jacob.jun.pan@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 2/5] iommu/vt-d: Allow SVA with device-specific IOPF

> From: Lu Baolu <baolu.lu@...ux.intel.com>
> Sent: Thursday, March 9, 2023 10:57 AM
> 
> @@ -4650,7 +4650,18 @@ static int intel_iommu_enable_sva(struct device
> *dev)
>  	if (!(iommu->flags & VTD_FLAG_SVM_CAPABLE))
>  		return -ENODEV;
> 
> -	if (!info->pasid_enabled || !info->pri_enabled || !info->ats_enabled)
> +	if (!info->pasid_enabled)
> +		return -EINVAL;
> +

I think you still want to check ats_enabled even for device specific IOPF.