linux-kernel - Re: [PATCH] staging: axis-fifo: initialize timeouts in probe only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1797409.3VsfAaAtOV@suse>
Date:   Thu, 16 Mar 2023 12:13:23 +0100
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Khadija Kamran <kamrankhadijadj@...il.com>
Cc:     Alison Schofield <alison.schofield@...el.com>,
        outreachy@...ts.linux.dev,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH] staging: axis-fifo: initialize timeouts in probe only

On giovedì 16 marzo 2023 10:50:50 CET Khadija Kamran wrote:
> On Wed, Mar 15, 2023 at 05:44:47PM +0100, Fabio M. De Francesco wrote:
> > On mercoledì 15 marzo 2023 14:56:27 CET Khadija Kamran wrote:
> > > On Wed, Mar 15, 2023 at 02:13:51PM +0100, Fabio M. De Francesco wrote:
> > > > On mercoledì 15 marzo 2023 13:32:55 CET Khadija Kamran wrote:

[snip]

> > > > I suppose that "w=1" is a typo. The option is enabled with "W=1"
> > > > (capital
> > > > case, Linux and all UNIX-like are case-sensitive).
> > > 
> > > Okay. I should re-run it with "W=1".
> > > 
> > > > > But it is taking a lot of time, is there any way of
> > > > > speeding it up?
> > > > 
> > > > What is you choice for 'X' in "-jX"?
> > > 
> > > I used "-j4".
> > > 
> > > > Did you try with the exact number of logical cores?
> > > > Are you building into a VM with enough logical cores?
> > > > If you are building into a VM, did you reserve enough RAM?
> > > 
> > > I am using Ubuntu 22.04.01 with the help of VM on VMware.
> > > My machine has 13GB RAM and 2 processors(4 cores each).
> > 
> > Therefore, you are using a Linux guest on a Linux host. This is a wise
> > choice. However, you didn't say where you are running your builds...
> 
> Hey Fabio!
> 
> I am not using a Linux guest on Linux host. Sorry if I did not explain
> it right. I am using Windows 10 and in order to run Ubuntu, I have
> created a VM(on VMWare). This VM has 13GB RAM and 2 processors(4 cores
> each).
> Thank you!
> 
> Regards,
> Khadija

Khadija,

I'm not yet sure whether or not you are doing well with reserving 13GB to a 
VM. First of all you should better use multiples of 2GB. Furthermore it looks 
too much memory unless you have a total "real" RAM in your host exceeding 
18GB. You must be sure you are leaving enough room for the Windows host to run 
smoothly and avoid too much swapping to/from disk.

At the same time I doubt that you can reserve 8 logical cores (2x4) for 
running the VM on VMWare.

However, we have time to investigate and adjust your configuration (if it 
really needs to be fine tuned). I'll try to reach you on IRC, open a private 
window, and assist with this task ASAP.

At the moment I'd prefer to see you focusing on getting your first patch 
accepted by Greg.

Thanks,

Fabio 
 
> > I mean, the better things to do are the following steps:
> > 
> > 1) Your workspace with the staging tree should stay in the host.
> > 2) Shut down your guest in order to have all RAM and all logical 
processors
> > available for the build.
> > 3) Run "make -j8" in the host. Since you shutdown your guest VM you can 
use
> > all 8 logical cores and the maximum available RAM (without the VM draining
> > resources while building)
> > 4) When the build is done, switch on your VM on VMware with at least 4
> > logical cores and 6GB of reserved RAM.
> > 5) Mount your cloned base directory as a shared folder between host and
> > guest. 6) In the guest, 'cd' to the shared folder and then run "make
> > modules_install install" (in the guest, attention). This will install and
> > configure the kernel, the modules, GRUB2 and everything else in your guest
> > VM.
> > 7) Reboot the VM and test your patches.
> > 
> > This procedure will speed up your next builds.
> > The fundamental point is that you don't need to partition precious 
resources
> > while building, Do everything without running the VM and switch it on only
> > for install and tests. Since you only build in the host but never install
> > and boot in it, you don't risk any system's damage.
> > 
> > This is what I do for Kernel development purposes.
> > 
> > I hope it helps to answer your question about how to run fast 
recompilation.
> > 
> > Fabio
> >