linux-kernel - Re: [PATCH] staging: axis-fifo: initialize timeouts in probe only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1902746.IobQ9Gjlxr@suse>
Date:   Thu, 16 Mar 2023 12:39:31 +0100
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Khadija Kamran <kamrankhadijadj@...il.com>
Cc:     Nathan Chancellor <nathan@...nel.org>,
        Alison Schofield <alison.schofield@...el.com>,
        outreachy@...ts.linux.dev,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: axis-fifo: initialize timeouts in probe only

On giovedì 16 marzo 2023 11:17:05 CET Khadija Kamran wrote:
> On Wed, Mar 15, 2023 at 05:24:23PM +0100, Fabio M. De Francesco wrote:
> > On mercoledì 15 marzo 2023 16:06:56 CET Nathan Chancellor wrote:
> > > Hi Khadija,
> > > 
> > > On Wed, Mar 15, 2023 at 07:22:39PM +0500, Khadija Kamran wrote:
> > > > On Wed, Mar 15, 2023 at 02:34:31PM +0100, Fabio M. De Francesco wrote:
> > > > > Aside from what I said and asked for with the other message of this
> > > > > same
> > > > > thread, please take note that you can build a specific module if you
> > > > > prefer
> > > > > not to re-build the whole kernel and other modules at the same time.
> > > > > 
> > > > > I'm pretty sure that the instructions to do so are in the
> > > > > OutreachyFirstPatch
> > > > > tutorial.
> > > > > 
> > > > > If they are not there, please let us know.
> > > > > 
> > > > > Fabio
> > > > 
> > > > Hey Fabio!
> > > > 
> > > > In the Outreachy FirstPatchTutorial under the 'Compiling only part of
> > > > the kernel' section there are ways to compile only some part of the
> > > > kernel.
> > > > 
> > > > I have tried using "make W=1 drivers/staging/axis-fifo/" and it says
> > > > 'nothing to be done for'.
> > > 
> > > Is CONFIG_XIL_AXIS_FIFO enabled in your configuration?
> > 
> > @Khadija:
> > 
> > Maybe that you won't find CONFIG_XIL_AXIS_FIFO among the staging drivers
> > entries while using "make menuconfig" (or the other similar commands for
> > working with the configuration).
> > 
> > In that case, first enable the CONFIG_OF option if disabled.
> > CONFIG_XIL_AXIS_FIFO depends on the former.
> > 
> > For "CONFIG_XIL_AXIS_FIFO depends on CONFIG_OF" we mean that you can the
> > former if and only if the latter is already enabled.
> > 
> > Actually, CONFIG_XIL_AXIS_FIFO depends also on two other options. However
> > you
> > shouldn't worry about those others because they are commonly enabled in 
more
> > than 99% of PC distributions.
> 
> Hey Fabio!
> 
> I have checked in my .config file and both options are enabled. The file
> says,
> CONFIG_OF=y
> CONFIG_HAS_IOMEM=y
> 
> The "make menuconfig" shows 'Xilinx AXI-Stream FIFO IP core driver' with
> built-in selection [*].
> The problem I am having here is that in the OutreachyFirstPatch
> tutorial, it asks you to change [*] -> [m], but I cannot change it.
> 
> Kindly help me with this!

Hi Khadija,

Sorry for being here so late.

I just saw also your other messages with further help requests.
Please do other work while waiting for help on a specific issue. 

If I understand you correctly, you are saying that you can only build axis-
fifo in-kernel because you cannot change the '*' to 'm'. Correct?

If so, you have probably touched other configuration options in a way that 
forces that driver to work only if compiled in-kernel). Therefore, I'd restart 
from scratch.

Please delete your current .config and make a copy of the one from your 
running kernel. Then check the three options Alison and I were talking about. 

Remember that you cannot see the axis-fifo module entry (CONFIG_XIL_AXIS_FIFO) 
in "Device Drivers" -> "Staging Drivers" section if you have not yet enabled  
(either with 'm' or 'y') CONFIG_OF and CONFIG_HAS_IOMEM. 

Now you should end up with a visible CONFIG_XIL_AXIS_FIFO that can be enabled 
as a module with 'm'. 

Let me know if this procedure works.

Fabio

> Thank you!
> Regards,
> Khadija
> 
> > > > Should I start with the steps to reproduce? :'(
> > > 
> > > I did see a report of this same warning occurring with GCC but the
> > > report I commented on cane from clang/LLVM; using that toolchain may
> > > make it easier for you to reproduce this issue. The robot's reproduction
> > > instructions are fine but I think doing it manually is actually simpler.
> > > 
> > > Ubuntu 22.04 should have a pretty modern version of clang/LLVM, which
> > > you can install via 'sudo apt install clang lld llvm'.
> > > https://apt.llvm.org is another resource.
> > 
> > @Nathan: Congratulations, you now have another clang/LLVM adept!
> > (Obviously, I'm just kidding :-))
> > 
> > Fabio