linux-kernel - Re: [PATCH v1 1/1] regulator: s5m8767: Replace of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <306b94ce-1f45-43a2-ad27-567fa5c235ce@sirena.org.uk>
Date:   Thu, 16 Mar 2023 13:10:46 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH v1 1/1] regulator: s5m8767: Replace of_gpio.h with what
 indeed is used

On Thu, Mar 16, 2023 at 02:01:13PM +0200, Andy Shevchenko wrote:
> of_gpio.h in this driver is solely used as a proxy to other headers.
> This is incorrect usage of the of_gpio.h. Replace it .h with what
> indeed is used in the code.

This breaks an x86 allmodconfig build:

/build/stage/linux/drivers/regulator/s5m8767.c: In function ‘s5m8767_pmic_dt_parse_dvs_gpio’:
/build/stage/linux/drivers/regulator/s5m8767.c:492:24: error: implicit declaration of function ‘of_get_named_gpio’ [-Werror=implicit-function-declaration]
  492 |                 gpio = of_get_named_gpio(pmic_np,
      |                        ^~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)