[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZBMZgSb0FXt7OIJz@smile.fi.intel.com>
Date: Thu, 16 Mar 2023 15:28:33 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Mark Brown <broonie@...nel.org>
Cc: Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org,
linux-samsung-soc@...r.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH v1 1/1] regulator: s5m8767: Replace of_gpio.h with what
indeed is used
On Thu, Mar 16, 2023 at 01:10:46PM +0000, Mark Brown wrote:
> On Thu, Mar 16, 2023 at 02:01:13PM +0200, Andy Shevchenko wrote:
> > of_gpio.h in this driver is solely used as a proxy to other headers.
> > This is incorrect usage of the of_gpio.h. Replace it .h with what
> > indeed is used in the code.
>
> This breaks an x86 allmodconfig build:
>
> /build/stage/linux/drivers/regulator/s5m8767.c: In function ‘s5m8767_pmic_dt_parse_dvs_gpio’:
> /build/stage/linux/drivers/regulator/s5m8767.c:492:24: error: implicit declaration of function ‘of_get_named_gpio’ [-Werror=implicit-function-declaration]
> 492 | gpio = of_get_named_gpio(pmic_np,
> | ^~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
Oh, sorry for that. I missed something.
Please, ignore this one, it should be different one.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists