linux-kernel - Re: [PATCH v7 3/5] dmaengine: dw-edma: Add support for native HDMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02216197-6cbd-319d-1015-bfb4449ead85@metafoo.de>
Date:   Sat, 18 Mar 2023 06:49:41 -0700
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     Cai Huoqing <cai.huoqing@...ux.dev>, fancer.lancer@...il.com
Cc:     Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Vinod Koul <vkoul@...nel.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org,
        linux-pci@...r.kernel.org
Subject: Re: [PATCH v7 3/5] dmaengine: dw-edma: Add support for native HDMA

On 3/14/23 18:28, Cai Huoqing wrote:
> Add support for HDMA NATIVE, as long the IP design has set
>
> diff --git a/drivers/dma/dw-edma/dw-hdma-v0-regs.h b/drivers/dma/dw-edma/dw-hdma-v0-regs.h
> new file mode 100644
> index 000000000000..0a6032aa1a33
> --- /dev/null
> +++ b/drivers/dma/dw-edma/dw-hdma-v0-regs.h
> @@ -0,0 +1,130 @@
>
> +struct dw_hdma_v0_ch_regs {
> [...]
> +	u32 msi_msgdata;			/* 0x00a8 */
> +	u32 padding_2[21];			/* 0x00ac..0x00e8 */
The comment here is wrong. This goes all the way to 0x00fc.
> +} __packed;
> +