[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZBfGvRL8cHuj1tJF@chq-MS-7D45>
Date: Mon, 20 Mar 2023 10:36:45 +0800
From: Cai Huoqing <cai.huoqing@...ux.dev>
To: Lars-Peter Clausen <lars@...afoo.de>
Cc: fancer.lancer@...il.com,
Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
Vinod Koul <vkoul@...nel.org>,
Jingoo Han <jingoohan1@...il.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof Wilczyński <kw@...ux.com>,
Rob Herring <robh@...nel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org,
linux-pci@...r.kernel.org
Subject: Re: [PATCH v7 3/5] dmaengine: dw-edma: Add support for native HDMA
On 18 3月 23 06:49:41, Lars-Peter Clausen wrote:
> On 3/14/23 18:28, Cai Huoqing wrote:
> > Add support for HDMA NATIVE, as long the IP design has set
> >
> > diff --git a/drivers/dma/dw-edma/dw-hdma-v0-regs.h b/drivers/dma/dw-edma/dw-hdma-v0-regs.h
> > new file mode 100644
> > index 000000000000..0a6032aa1a33
> > --- /dev/null
> > +++ b/drivers/dma/dw-edma/dw-hdma-v0-regs.h
> > @@ -0,0 +1,130 @@
> >
> > +struct dw_hdma_v0_ch_regs {
> > [...]
> > + u32 msi_msgdata; /* 0x00a8 */
> > + u32 padding_2[21]; /* 0x00ac..0x00e8 */
> The comment here is wrong. This goes all the way to 0x00fc.
Will fix, if send next version.
Thanks,
Cai-
> > +} __packed;
> > +
>
Powered by blists - more mailing lists