linux-kernel - Re: [PATCH v3 2/3] dt-bindings: thermal: qcom-spmi-adc-tm5: Use generic ADC node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230318164449.1df8d0be@jic23-huawei>
Date:   Sat, 18 Mar 2023 16:44:49 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Marijn Suijten <marijn.suijten@...ainline.org>
Cc:     Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Rob Herring <robh@...nel.org>, phone-devel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Martin Botka <martin.botka@...ainline.org>,
        Jami Kettunen <jami.kettunen@...ainline.org>,
        iio@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 2/3] dt-bindings: thermal: qcom-spmi-adc-tm5: Use
 generic ADC node name

On Thu, 16 Mar 2023 23:44:50 +0100
Marijn Suijten <marijn.suijten@...ainline.org> wrote:

> On 2023-03-16 17:44:28, Jonathan Cameron wrote:
> <snip>
> > > Should it inherit the common binding, or was it omitted for a reason?  
> > 
> > Harmless but little point as far as I can see given we don't happen
> > to have any of the generic elements defined in the generic channel
> > binding.  
> 
> Supposedly the reg property, and now also the node name.  Up to you to
> say whether I should inherit this (and strip out the common bits) or
> just focus on renaming the node name in the existing binding to channel.
> 
> - Marijn

Just rename the node name.

Jonathan