linux-kernel - Re: [PATCH] ALSA: portman2x4: remove unused portman_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87lejtma93.wl-tiwai@suse.de>
Date:   Sun, 19 Mar 2023 09:11:04 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Tom Rix <trix@...hat.com>
Cc:     perex@...ex.cz, tiwai@...e.com, nathan@...nel.org,
        ndesaulniers@...gle.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] ALSA: portman2x4: remove unused portman_read_command,data functions

On Sat, 18 Mar 2023 14:52:29 +0100,
Tom Rix wrote:
> 
> clang with W=1 reports
> sound/drivers/portman2x4.c:185:18: error: unused function
>   'portman_read_command' [-Werror,-Wunused-function]
> static inline u8 portman_read_command(struct portman *pm)
>                  ^
> sound/drivers/portman2x4.c:195:18: error: unused function
>   'portman_read_data' [-Werror,-Wunused-function]
> static inline u8 portman_read_data(struct portman *pm)
>                  ^
> These static functions are not used, so remove them.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Applied now, thanks.


Takashi