linux-kernel - Re: [PATCH] ALSA: drivers: Remove the unused variable portman_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 19 Mar 2023 09:12:14 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] ALSA: drivers: Remove the unused variable portman_read_data

On Sun, 19 Mar 2023 09:06:05 +0100,
Takashi Iwai wrote:
> 
> On Fri, 17 Mar 2023 07:33:38 +0100,
> Jiapeng Chong wrote:
> > 
> > Variable portman_read_data is not effectively used, so delete it.
> > 
> > sound/drivers/portman2x4.c:195:18: warning: unused function 'portman_read_data'.
> > 
> > Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4557
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> 
> Thanks, applied now.

... and now I see Tom's patch removing one more unused one, so I took
Tom's fix instead of yours.
  https://lore.kernel.org/r/20230318135229.1685266-1-trix@redhat.com


thanks,

Takashi