linux-kernel - Re: [PATCH] staging: most: use inline functions for iface_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBh/Yw49fubf1GDb@kroah.com>
Date:   Mon, 20 Mar 2023 16:44:35 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Menna Mahmoud <eng.mennamahmoud.mm@...il.com>
Cc:     outreachy@...ts.linux.dev, parthiban.veerasooran@...rochip.com,
        christian.gromm@...rochip.com, drv@...lo.com, dave@...olabs.net,
        yang.lee@...ux.alibaba.com, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev, Julia Lawall <julia.lawall@...ia.fr>
Subject: Re: [PATCH] staging: most:  use inline functions for iface_to_hdm

On Mon, Mar 20, 2023 at 12:33:35PM +0200, Menna Mahmoud wrote:
> Convert `iface_to_hdm` macro into a static inline function.
> it is not great to have macro that use `container_of` macro,
> because from looking at the definition one cannot tell
> what type it applies to.
> 
> One can get the same benefit from an efficiency point of view
> by making an inline function.
> 
> Suggested-by: Julia Lawall <julia.lawall@...ia.fr>
> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@...il.com>
> ---
>  drivers/staging/most/dim2/dim2.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Your subject line has a "  " when it should have just a " " :(

Please fix up and send a v2.

thanks,

greg k-h