linux-kernel - Re: [PATCH] staging: most: use inline functions for iface_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d0ba154b-c975-574e-657e-c9c7098231af@gmail.com>
Date:   Mon, 20 Mar 2023 20:26:22 +0200
From:   Menna Mahmoud <eng.mennamahmoud.mm@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     outreachy@...ts.linux.dev, parthiban.veerasooran@...rochip.com,
        christian.gromm@...rochip.com, drv@...lo.com, dave@...olabs.net,
        yang.lee@...ux.alibaba.com, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev, Julia Lawall <julia.lawall@...ia.fr>
Subject: Re: [PATCH] staging: most: use inline functions for iface_to_hdm


On ٢٠‏/٣‏/٢٠٢٣ ١٧:٤٤, Greg KH wrote:
> On Mon, Mar 20, 2023 at 12:33:35PM +0200, Menna Mahmoud wrote:
>> Convert `iface_to_hdm` macro into a static inline function.
>> it is not great to have macro that use `container_of` macro,
>> because from looking at the definition one cannot tell
>> what type it applies to.
>>
>> One can get the same benefit from an efficiency point of view
>> by making an inline function.
>>
>> Suggested-by: Julia Lawall <julia.lawall@...ia.fr>
>> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@...il.com>
>> ---
>>   drivers/staging/most/dim2/dim2.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
> Your subject line has a "  " when it should have just a " " :(
I see, I will fix it.
>
> Please fix up and send a v2.
I will.
>
> thanks,
>
> greg k-h

Thanks,

Menna