linux-kernel - Re: [PATCH 2/2] platform/x86/intel/pmt/telemetry: Add driver version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a6d27ad18452d13840cb4cdd2f17cef7dbe0275c.camel@linux.intel.com>
Date:   Mon, 20 Mar 2023 10:03:26 -0700
From:   "David E. Box" <david.e.box@...ux.intel.com>
To:     Hans de Goede <hdegoede@...hat.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     irenic.rajneesh@...il.com, markgross@...nel.org,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 2/2] platform/x86/intel/pmt/telemetry: Add driver version

On Mon, 2023-03-20 at 15:18 +0100, Hans de Goede wrote:
> Hi,
> 
> On 3/17/23 14:35, Andy Shevchenko wrote:
> > On Fri, Mar 17, 2023 at 12:57 AM David E. Box
> > <david.e.box@...ux.intel.com> wrote:
> > > 
> > > Add a driver version number to make it easier to track changes in
> > > backported kernels.
> > 
> > Sorry, but NAK. As Greg KH said, we do not use this anymore (in Git
> > era) — the SHA from the Git _is_ the version of the driver.
> 
> I agree with Andy per driver version numbers are really not useful.
> 
> Generally speaking the version number will get updated say once
> per upstream kernel-release in a separate commit, 

> but there is
> no guarantee that commit will get cherry-picked together with
> other cherry-picked fixes.

Good point. Thanks.

David


> 
> So for downstream kernels these version numbers really don't
> have any meaning and as such are useless.
> 
> Regards,
> 
> Hans
>