linux-kernel - Re: [PATCH] acpi: check for null return of devm_kzalloc in fch_misc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jwQwepjFhWQXnQndGp060WGD4LjBqot5VrV-gpL46vHg@mail.gmail.com>
Date:   Mon, 20 Mar 2023 18:06:07 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Kang Chen <void0red@...il.com>
Cc:     lenb@...nel.org, rafael@...nel.org, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] acpi: check for null return of devm_kzalloc in fch_misc_setup

On Sun, Feb 26, 2023 at 6:54 AM Kang Chen <void0red@...il.com> wrote:
>
> devm_kzalloc may fail, clk_data->name might be null and will
> cause illegal address access later.
>
> Signed-off-by: Kang Chen <void0red@...il.com>
> ---
>  drivers/acpi/acpi_apd.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index 3bbe2276c..80f945cbe 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -83,6 +83,8 @@ static int fch_misc_setup(struct apd_private_data *pdata)
>         if (!acpi_dev_get_property(adev, "clk-name", ACPI_TYPE_STRING, &obj)) {
>                 clk_data->name = devm_kzalloc(&adev->dev, obj->string.length,
>                                               GFP_KERNEL);
> +               if (!clk_data->name)
> +                       return -ENOMEM;
>
>                 strcpy(clk_data->name, obj->string.pointer);
>         } else {
> --

Applied as 6.4 material with some edits in the subject and changelog, thanks!