linux-kernel - Re: [PATCH 0/2] spi: imx: Fix cleanup in remove and convert to .remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167933825108.203761.2340402039311088951.b4-ty@kernel.org>
Date:   Mon, 20 Mar 2023 18:50:51 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Stefan Agner <stefan@...er.ch>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] spi: imx: Fix cleanup in remove and convert to
 .remove_new()

On Mon, 06 Mar 2023 07:57:31 +0100, Uwe Kleine-König wrote:
> this small series converts the spi-imx driver to .remove_new(). The
> motivation for this tree-wide effort are drivers that don't properly
> cleanup and return an error code. This is broken as this results in
> resource leaks. The spi-imx driver is such a driver. The idea is that if
> the remove callback returns void it's obvious that an early error return
> is wrong.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/2] spi: imx: Don't skip cleanup in remove's error path
      commit: 11951c9e3f364d7ae3b568a0e52c8335d43066b5
[2/2] spi: imx: Convert to platform remove callback returning void
      commit: 423e548127223d597bb65a149ebcb3c50ea08846

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark