linux-kernel - RE: [PATCH 1/1] x86/irq: Add hardcoded hypervisor interrupts to /proc/stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR21MB1688FCB69EAF96199D13FB64D7809@BYAPR21MB1688.namprd21.prod.outlook.com>
Date:   Mon, 20 Mar 2023 20:37:04 +0000
From:   "Michael Kelley (LINUX)" <mikelley@...rosoft.com>
To:     "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/1] x86/irq: Add hardcoded hypervisor interrupts to
 /proc/stat

From: Michael Kelley (LINUX) <mikelley@...rosoft.com> Sent: Monday, February 27, 2023 10:46 AM
> 
> Some hypervisor interrupts (such as for Hyper-V VMbus and Hyper-V timers)
> have hardcoded interrupt vectors on x86 and don't have Linux IRQs assigned.
> These interrupts are shown in /proc/interrupts, but are not reported in
> the first field of the "intr" line in /proc/stat because the x86 version
> of arch_irq_stat_cpu() doesn't include them.
> 
> Fix this by adding code to arch_irq_stat_cpu() to include these interrupts,
> similar to existing interrupts that don't have Linux IRQs.
> 
> Signed-off-by: Michael Kelley <mikelley@...rosoft.com>

Gentle ping.  Any comments on this patch?  Seems pretty
straightforward to me ....

Michael

> ---
>  arch/x86/kernel/irq.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
> index 766ffe3..9f668d2 100644
> --- a/arch/x86/kernel/irq.c
> +++ b/arch/x86/kernel/irq.c
> @@ -211,6 +211,13 @@ u64 arch_irq_stat_cpu(unsigned int cpu)
>  #ifdef CONFIG_X86_MCE_THRESHOLD
>  	sum += irq_stats(cpu)->irq_threshold_count;
>  #endif
> +#ifdef CONFIG_X86_HV_CALLBACK_VECTOR
> +	sum += irq_stats(cpu)->irq_hv_callback_count;
> +#endif
> +#if IS_ENABLED(CONFIG_HYPERV)
> +	sum += irq_stats(cpu)->irq_hv_reenlightenment_count;
> +	sum += irq_stats(cpu)->hyperv_stimer0_count;
> +#endif
>  #ifdef CONFIG_X86_MCE
>  	sum += per_cpu(mce_exception_count, cpu);
>  	sum += per_cpu(mce_poll_count, cpu);
> --
> 1.8.3.1