[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZBfiKc2IHtonxy7o@google.com>
Date: Sun, 19 Mar 2023 21:33:45 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: Matthias Benkmann <matthias.benkmann@...il.com>,
linux-input@...r.kernel.org, Nate Yocom <nate@...om.org>,
hadess@...ess.net, benjamin.tissoires@...hat.com,
linux-kernel@...r.kernel.org, Pavel Rojtberg <rojtberg@...il.com>
Subject: Re: [PATCH v3] Fix incorrectly applied patch for MAP_PROFILE_BUTTON
On Sat, Mar 18, 2023 at 07:00:47PM +0100, Andi Shyti wrote:
> On Sat, Mar 18, 2023 at 04:21:06PM +0100, Matthias Benkmann wrote:
> > When the linked patch was applied,
>
> Please refer to the patch as "commit fff1011a26d6 ("Input: xpad -
> add X-Box Adaptive Profile button")" and not as "linked patch".
>
> > one hunk ended up in the wrong function. This patch moves it to where
> > it probably belongs.
>
> probably? We need to be sure here :)
>
> Besides, please, use the imperative form, not "this patch moves"
> but "move what where", please be more specific.
Reworded and applied, thank you.
--
Dmitry
Powered by blists - more mailing lists