linux-kernel - Re: [PATCH 09/20] clk: renesas: remove MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877cvbu1cc.fsf@esperi.org.uk>
Date:   Mon, 20 Mar 2023 11:08:35 +0000
From:   Nick Alcock <nick.alcock@...cle.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     mcgrof@...nel.org, linux-modules@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        linux-renesas-soc@...r.kernel.org, linux-clk@...r.kernel.org,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Adam Ford <aford173@...il.com>
Subject: Re: [PATCH 09/20] clk: renesas: remove MODULE_LICENSE in non-modules

On 28 Feb 2023, Geert Uytterhoeven outgrape:

> Hi Nick,
>
> On Tue, Feb 28, 2023 at 2:03 PM Nick Alcock <nick.alcock@...cle.com> wrote:
>> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
>> are used to identify modules. As a consequence, uses of the macro
>> in non-modules will cause modprobe to misidentify their containing
>> object file as a module when it is not (false positives), and modprobe
>> might succeed rather than failing with a suitable error message.
>>
>> So remove it in the files in this commit, none of which can be built as
>> modules.
>>
>> Signed-off-by: Nick Alcock <nick.alcock@...cle.com>
>> Suggested-by: Luis Chamberlain <mcgrof@...nel.org>
>
> Thanks for your patch!
>
>>  drivers/clk/renesas/rcar-usb2-clock-sel.c | 1 -
>
> I think it would make sense to make CLK_RCAR_USB2_CLOCK_SEL
> tristate. Shimoda-san?

This patch touches three files, so I hope that means the MODULE_LICENSE
removal from drivers/clk/renesas/renesas-cpg-mssr.c and
drivers/clk/renesas/rzg2l-cpg.c is OK :)