linux-kernel - Re: [PATCH] block: add queue_logical_block_mask() and bdev_logical_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZBhgy/+u/5+79uZq@infradead.org>
Date:   Mon, 20 Mar 2023 06:34:03 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Yangtao Li <frank.li@...o.com>
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: add queue_logical_block_mask() and
 bdev_logical_block_mask()

On Fri, Mar 10, 2023 at 04:24:13PM +0800, Yangtao Li wrote:
> Introduce queue_logical_block_mask() and bdev_logical_block_mask()
> to simplify code, which replace (queue_logical_block_size(q) - 1)
> and (bdev_logical_block_size(bdev) - 1).
> 
> Signed-off-by: Yangtao Li <frank.li@...o.com>
> ---
> Like wo done for fs.
> This round we add helpers and start converting in the next cycle.
> https://lore.kernel.org/lkml/20230309124035.15820-1-frank.li@vivo.com/

Please always send the helper with the actual users.

And for use in file systems the request_queue is very much the
wrong object to work on.  All the block layer APIs for consumers like
file systems are based on struct block_device.