linux-kernel - Re: [PATCH] media: av7110: put spaces around operators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <487b75ea-aecd-5fdc-c2a2-5f5080f8647e@xs4all.nl>
Date:   Tue, 21 Mar 2023 16:08:30 +0100
From:   Hans Verkuil <hverkuil-cisco@...all.nl>
To:     Daniel Watson <ozzloy@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: av7110: put spaces around operators

Hi Daniel,

On 21/03/2023 07:45, Daniel Watson wrote:
> put spaces around '=' and '<=' to match style from checkpatch
> 
> Signed-off-by: Daniel Watson <ozzloy@...il.com>
> ---
>  drivers/staging/media/av7110/av7110_hw.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/media/av7110/av7110_hw.h b/drivers/staging/media/av7110/av7110_hw.h
> index 6380d8950c695..3274146c401f1 100644
> --- a/drivers/staging/media/av7110/av7110_hw.h
> +++ b/drivers/staging/media/av7110/av7110_hw.h
> @@ -402,8 +402,8 @@ static inline u32 irdebi(struct av7110 *av7110, u32 config, int addr, u32 val, u
>  {
>  	u32 res;
>  
> -	res=av7110_debiread(av7110, config, addr, count);
> -	if (count<=4)
> +	res = av7110_debiread(av7110, config, addr, count);
> +	if (count <= 4)
>  		memcpy(av7110->debi_virt, (char *) &res, count);
>  	return res;
>  }
> @@ -424,7 +424,7 @@ static inline u32 rdebi(struct av7110 *av7110, u32 config, int addr, u32 val, un
>  	u32 res;
>  
>  	spin_lock_irqsave(&av7110->debilock, flags);
> -	res=av7110_debiread(av7110, config, addr, count);
> +	res = av7110_debiread(av7110, config, addr, count);
>  	spin_unlock_irqrestore(&av7110->debilock, flags);
>  	return res;
>  }

I'm not sure what the point it of these two fixes since this driver is
full of such things.

In any case, I'm rejecting this. Just leave this driver alone, it's not
worth the effort.

If you are doing this as part of some mentorship program, then skip the
drivers/staging/media directory, it's not suitable for that.

Regards,

	Hans