[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZBn3wmTkcZ0WC6iW@trent-reznor>
Date: Tue, 21 Mar 2023 11:30:26 -0700
From: Daniel Watson <ozzloy@...il.com>
To: Hans Verkuil <hverkuil-cisco@...all.nl>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: av7110: put spaces around operators
On Tue, Mar 21, 2023 at 04:08:30PM +0100, Hans Verkuil wrote:
> Hi Daniel,
>
Hi!
> I'm not sure what the point it of these two fixes since this driver is
> full of such things.
these fixes were the only ones where checkpatch said "spaces required
around that ..." for this file.
> In any case, I'm rejecting this. Just leave this driver alone, it's not
> worth the effort.
ok.
> If you are doing this as part of some mentorship program, then skip the
i'm doing this on my own. i read that newbies should do about 10 minor
patches to get familiar with the process before doing something more
substantial.
> drivers/staging/media directory, it's not suitable for that.
ok, i'll try other drivers in staging. i'll also see about getting a
mentor.
thanks again!
Powered by blists - more mailing lists