linux-kernel - RE: [PATCH] wifi: rtw88: remove unused rtw_pci_get_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Mar 2023 00:32:26 +0000
From:   Ping-Ke Shih <pkshih@...ltek.com>
To:     Tom Rix <trix@...hat.com>,
        "tony0620emma@...il.com" <tony0620emma@...il.com>,
        "kvalo@...nel.org" <kvalo@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "nathan@...nel.org" <nathan@...nel.org>,
        "ndesaulniers@...gle.com" <ndesaulniers@...gle.com>
CC:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>
Subject: RE: [PATCH] wifi: rtw88: remove unused rtw_pci_get_tx_desc function



> -----Original Message-----
> From: Tom Rix <trix@...hat.com>
> Sent: Tuesday, March 21, 2023 7:35 AM
> To: tony0620emma@...il.com; kvalo@...nel.org; davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; nathan@...nel.org; ndesaulniers@...gle.com
> Cc: linux-wireless@...r.kernel.org; netdev@...r.kernel.org; linux-kernel@...r.kernel.org;
> llvm@...ts.linux.dev; Tom Rix <trix@...hat.com>
> Subject: [PATCH] wifi: rtw88: remove unused rtw_pci_get_tx_desc function
> 
> clang with W=1 reports
> drivers/net/wireless/realtek/rtw88/pci.c:92:21: error:
>   unused function 'rtw_pci_get_tx_desc' [-Werror,-Wunused-function]
> static inline void *rtw_pci_get_tx_desc(struct rtw_pci_tx_ring *tx_ring, u8 idx)
>                     ^
> This function is not used, so remove it.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Reviewed-by: Ping-Ke Shih <pkshih@...ltek.com>

> ---
>  drivers/net/wireless/realtek/rtw88/pci.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
> index b4bd831c9845..6a8e6ee82069 100644
> --- a/drivers/net/wireless/realtek/rtw88/pci.c
> +++ b/drivers/net/wireless/realtek/rtw88/pci.c
> @@ -89,13 +89,6 @@ static void rtw_pci_write32(struct rtw_dev *rtwdev, u32 addr, u32 val)
>         writel(val, rtwpci->mmap + addr);
>  }
> 
> -static inline void *rtw_pci_get_tx_desc(struct rtw_pci_tx_ring *tx_ring, u8 idx)
> -{
> -       int offset = tx_ring->r.desc_size * idx;
> -
> -       return tx_ring->r.head + offset;
> -}
> -
>  static void rtw_pci_free_tx_ring_skbs(struct rtw_dev *rtwdev,
>                                       struct rtw_pci_tx_ring *tx_ring)
>  {
> --
> 2.27.0